174b989c3SRobert MustacchiThis directory contains the 'common code' to the ixgbe driver. This code 274b989c3SRobert Mustacchicomes from FreeBSD. 374b989c3SRobert Mustacchi 474b989c3SRobert MustacchiThe following are a subset of the current modifications that are being 574b989c3SRobert Mustacchimade to this common code to facilitate illumos specific features: 674b989c3SRobert Mustacchi 774b989c3SRobert Mustacchio IXGBE_REMOVED 874b989c3SRobert Mustacchi 974b989c3SRobert MustacchiThe IXGBE_REMOVED macro normally taks a pointer to the hardware address. 1074b989c3SRobert MustacchiHowever, that does not allow us to go through and actually do a useful 1174b989c3SRobert Mustacchicheck. Instead we modify all users of this macro to pass the struct 1274b989c3SRobert Mustacchiixgbe_hw of the ixgbe_t. Importantly, we also remove the current 1374b989c3SRobert Mustacchidefinition of IXGBE_REMOVED in ixbe_common.h and instead use the 1474b989c3SRobert Mustacchidefinition in ixgbe_osdep.h. 15*48ed61a7SRobert Mustacchi 16*48ed61a7SRobert Mustacchio ixgbe_get_oem_prod_version() 17*48ed61a7SRobert Mustacchi 18*48ed61a7SRobert MustacchiThis function has a smatch error. It checks for: 19*48ed61a7SRobert Mustacchi 20*48ed61a7SRobert Mustacchi if (offset == 0x0 && offset == NVM_INVALID_PTR) 21*48ed61a7SRobert Mustacchi 22*48ed61a7SRobert MustacchiThat condition can never occur. It should instead be: 23*48ed61a7SRobert Mustacchi 24*48ed61a7SRobert Mustacchi if (offset == 0x0 || offset == NVM_INVALID_PTR) 25